Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net): handle string ports for Socket.connect #1172

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Sep 14, 2022

Socket.connect with a string port (e.g. socket.connect('4317', 'localhost', () => {})) was previously creating an IPC span while it should have been creating a TCP span.

For example cassandra-driver is a package that uses this form of Socket.connect.

@seemk seemk requested a review from a team September 14, 2022 13:51
@seemk seemk changed the title fix: handle string ports for Socket.connect fix(net): handle string ports for Socket.connect Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1172 (5abfced) into main (c1a8622) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1172      +/-   ##
==========================================
+ Coverage   96.07%   96.31%   +0.24%     
==========================================
  Files          14       18       +4     
  Lines         892     1086     +194     
  Branches      191      216      +25     
==========================================
+ Hits          857     1046     +189     
- Misses         35       40       +5     
Impacted Files Coverage Δ
...ode/opentelemetry-instrumentation-net/src/utils.ts 92.00% <100.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 98.00% <0.00%> (ø)
...ode/opentelemetry-instrumentation-net/src/types.ts 100.00% <0.00%> (ø)
...lemetry-instrumentation-net/src/instrumentation.ts 98.07% <0.00%> (ø)

Copy link
Member

@rauno56 rauno56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice catch.

@rauno56 rauno56 merged commit aa6a0dd into open-telemetry:main Sep 14, 2022
@dyladan dyladan mentioned this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants