Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add applying patch debug log to pino module #1225

Merged

Conversation

Just-Sieb
Copy link
Contributor

Which problem is this PR solving?

Fixes #1203

Short description of the changes

  • Adds a debug log message when we patch the pino module

@Just-Sieb Just-Sieb requested a review from a team October 11, 2022 03:01
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 11, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Just-Sieb / name: Justin Siebert (f1b9761)

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #1225 (f1b9761) into main (180b336) will increase coverage by 3.09%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
+ Coverage   96.08%   99.18%   +3.09%     
==========================================
  Files          14        2      -12     
  Lines         893      122     -771     
  Branches      191       19     -172     
==========================================
- Hits          858      121     -737     
+ Misses         35        1      -34     
Impacted Files Coverage Δ
...emetry-instrumentation-pino/src/instrumentation.ts 100.00% <100.00%> (ø)
...metry-propagator-aws-xray/src/AWSXRayPropagator.ts
...trumentation-document-load/src/enums/EventNames.ts
...y-instrumentation-long-task/src/instrumentation.ts
...erator-aws-xray/src/internal/xray-id-generation.ts
...metry-propagator-ot-trace/src/OTTracePropagator.ts
...etry-plugin-react-load/src/enums/AttributeNames.ts
...strumentation-document-load/src/instrumentation.ts
...umentation-user-interaction/src/instrumentation.ts
...entation-document-load/src/enums/AttributeNames.ts
... and 7 more

@rauno56 rauno56 merged commit a2719c5 into open-telemetry:main Oct 17, 2022
@dyladan dyladan mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pino instrumentation does not log "Applying patch for" as other modules do
5 participants