Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@opentelemetry/instrumentation-fs is not instrumenting in case require("fs/promises") is used #1313

Closed
Flarna opened this issue Nov 29, 2022 · 1 comment · Fixed by #1375
Closed
Assignees
Labels

Comments

@Flarna
Copy link
Member

Flarna commented Nov 29, 2022

What version of OpenTelemetry are you using?

@opentelemetry/instrumentation-fs 0.5.1

Note that latest version 0.6.0 crashes in this case (see open-telemetry/opentelemetry-js#3448).

What version of Node are you using?

18.12.1

What did you do?

"use strict";
const { FsInstrumentation } = require("@opentelemetry/instrumentation-fs");
const { registerInstrumentations } = require("@opentelemetry/instrumentation");
registerInstrumentations({
    instrumentations: [
        new FsInstrumentation()
    ]
});
const fs = require("fs/promises");

What did you expect to see?

fs promise APIs should be instrumented

What did you see instead?

fs promise APIs are not instrumented

Additional context

see this comment

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants