-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change span names for socket-io #2495
Conversation
8b56ce9
to
17140b4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2495 +/- ##
=======================================
Coverage 90.88% 90.88%
=======================================
Files 159 159
Lines 7844 7844
Branches 1616 1616
=======================================
Hits 7129 7129
Misses 715 715 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the room should not be part of the span name and the operation should be first according to the span name of messaging spans.
Thanks for fixing it.
@povilasv please fix the lint error with |
17140b4
to
eff2981
Compare
eff2981
to
05712c6
Compare
@blumamir fixed, thanks! |
Which problem is this PR solving?
Socket io span names might contain high cardinality data. I'm removing roomId from span names so it doesn't.
Issue: #1937
Short description of the changes
... receive
.One question about should it be "receive", I think we might need to change it to "process"?
Given:
Ref: https://opentelemetry.io/docs/specs/semconv/messaging/messaging-spans/#consumer-spans