Skip to content

Commit 2d54408

Browse files
authored
ci: drop unsafe-perm in workflows (#5895)
1 parent 90ad17b commit 2d54408

File tree

3 files changed

+3
-15
lines changed

3 files changed

+3
-15
lines changed

.github/workflows/benchmark.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ jobs:
2020
container:
2121
image: ubuntu:24.04
2222
timeout-minutes: 10
23-
env:
24-
NPM_CONFIG_UNSAFE_PERM: true
2523
steps:
2624
# Apt packages:
2725
# - git: Needed for 'npm run submodule'

.github/workflows/sbom.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,12 @@ name: SBOM
22
on:
33
release:
44
types: [published]
5-
5+
66
permissions: read-all
77

88
jobs:
99
generate-sboms:
1010
runs-on: ubuntu-latest
11-
env:
12-
NPM_CONFIG_UNSAFE_PERM: true
1311
steps:
1412
- name: Checkout
1513
uses: actions/checkout@v5
@@ -32,13 +30,13 @@ jobs:
3230
echo "Generating SBOM for $dir_name"
3331
npm sbom --sbom-format=spdx --legacy-peer-deps --workspace ${dir} > "opentelemetry-js_${dir_name}.spdx.json"
3432
done
35-
33+
3634
- name: Generate SBOM for the API package
3735
if: startsWith(github.ref, 'refs/tags/api/')
3836
run: |
3937
npm sbom --sbom-format=spdx --legacy-peer-deps --workspace api > opentelemetry-js_api.spdx.json
4038
41-
- name: Generate SBOMs for experimental packages
39+
- name: Generate SBOMs for experimental packages
4240
if: startsWith(github.ref, 'refs/tags/experimental/')
4341
run: |
4442
for dir in $(find experimental/packages -mindepth 1 -maxdepth 1 -type d)

.github/workflows/unit-test.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ jobs:
2222
- "22"
2323
- "24"
2424
runs-on: ubuntu-latest
25-
env:
26-
NPM_CONFIG_UNSAFE_PERM: true
2725
steps:
2826
- name: Checkout
2927
uses: actions/checkout@v5
@@ -74,8 +72,6 @@ jobs:
7472
verbose: true
7573
node-windows-tests:
7674
runs-on: windows-latest
77-
env:
78-
NPM_CONFIG_UNSAFE_PERM: true
7975
steps:
8076
- name: Checkout
8177
uses: actions/checkout@v5
@@ -103,8 +99,6 @@ jobs:
10399
NODE_OPTIONS: '--no-experimental-strip-types'
104100
browser-tests:
105101
runs-on: ubuntu-latest
106-
env:
107-
NPM_CONFIG_UNSAFE_PERM: true
108102
steps:
109103
- name: Checkout
110104
uses: actions/checkout@v5
@@ -132,8 +126,6 @@ jobs:
132126
verbose: true
133127
webworker-tests:
134128
runs-on: ubuntu-latest
135-
env:
136-
NPM_CONFIG_UNSAFE_PERM: true
137129
steps:
138130
- name: Checkout
139131
uses: actions/checkout@v5

0 commit comments

Comments
 (0)