-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTLP Metrics Exporter #1109
Comments
Hi, I've been working on this feature, so you can assign the task to me. |
opentelemetry has separate exporter for spans and metrics. |
@davidwitten welcome to the project! just so you know we have weekly meetings on wednesdays at noon ET if you would like to join. |
@davidwitten in the future, if you're working on an issue please comment so we can assign it. It helps us to know which issues are being worked on. |
One thing I was wondering about when considering to use this from a browser front-end is how to protect the collector from spam. For example, by limiting the metrics (and labels) that can be ingested. Does anyone have experience with that? |
@dyladan @obecny Hi, I've been working on this issue. While creating the types, I noticed that the open-telemetry-proto in the repo is from 2 months ago. Should I update the proto to the most recent commit? I previously tried updating it, but it failed in my tests because the collector itself still used the old proto. Edit: I just noticed that v0.4.0 of the collector was released 2 days ago. After updating, the new proto works, so I will update my code to use that. |
Closing as the OTLP metrics exporter has already been implemented. |
Is your feature request related to a problem? Please describe.
Add the ability to export metrics using the OLTP protocol so we can export metrics to the opentelemetry-collector.
Describe the solution you'd like
It seems to make the most sense to add this ability to the opentelemetry-exporter-collector package. For reference, this functionality is already available in opentelemetry-go. I'm specifically interested in the implementation for the web.
PS: Maybe consider renaming this package to opentelemetry-exporter-otlp since the opentelemetry-collector is just one implementation of an OTLP collector.
Describe alternatives you've considered
Unless I missed something, I could not find an existing way of exporting metrics from the JS client over OTLP.
Additional context
The text was updated successfully, but these errors were encountered: