Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP Metrics Exporter #1109

Closed
backkem opened this issue May 27, 2020 · 7 comments
Closed

OTLP Metrics Exporter #1109

backkem opened this issue May 27, 2020 · 7 comments
Assignees

Comments

@backkem
Copy link

backkem commented May 27, 2020

Is your feature request related to a problem? Please describe.
Add the ability to export metrics using the OLTP protocol so we can export metrics to the opentelemetry-collector.

Describe the solution you'd like
It seems to make the most sense to add this ability to the opentelemetry-exporter-collector package. For reference, this functionality is already available in opentelemetry-go. I'm specifically interested in the implementation for the web.

PS: Maybe consider renaming this package to opentelemetry-exporter-otlp since the opentelemetry-collector is just one implementation of an OTLP collector.

Describe alternatives you've considered
Unless I missed something, I could not find an existing way of exporting metrics from the JS client over OTLP.

Additional context

@dyladan dyladan added the up-for-grabs Good for taking. Extra help will be provided by maintainers label May 27, 2020
@davidwitten
Copy link
Member

Hi, I've been working on this feature, so you can assign the task to me.

@obecny
Copy link
Member

obecny commented Jun 3, 2020

opentelemetry has separate exporter for spans and metrics.
opentelemetry-exporter-collector is for span we are missing for metrics.
if I were to rename it I could probably call it
opentelemetry-exporter-spans (renamed from opentelemetry-exporter-collector)
opentelemetry-exporter-metrics - OTLP Metrics Exporter

@vmarchaud vmarchaud removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jun 3, 2020
@dyladan
Copy link
Member

dyladan commented Jun 3, 2020

@davidwitten welcome to the project! just so you know we have weekly meetings on wednesdays at noon ET if you would like to join.

@dyladan
Copy link
Member

dyladan commented Jun 3, 2020

@davidwitten in the future, if you're working on an issue please comment so we can assign it. It helps us to know which issues are being worked on.

@backkem
Copy link
Author

backkem commented Jun 4, 2020

One thing I was wondering about when considering to use this from a browser front-end is how to protect the collector from spam. For example, by limiting the metrics (and labels) that can be ingested. Does anyone have experience with that?

@davidwitten
Copy link
Member

davidwitten commented Jun 18, 2020

@dyladan @obecny Hi, I've been working on this issue. While creating the types, I noticed that the open-telemetry-proto in the repo is from 2 months ago.

Should I update the proto to the most recent commit? I previously tried updating it, but it failed in my tests because the collector itself still used the old proto.

Edit: I just noticed that v0.4.0 of the collector was released 2 days ago. After updating, the new proto works, so I will update my code to use that.

@legendecas
Copy link
Member

Closing as the OTLP metrics exporter has already been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants