Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Default Span Configuration #1341

Closed
aravinsiva opened this issue Jul 22, 2020 · 5 comments
Closed

Remove Default Span Configuration #1341

aravinsiva opened this issue Jul 22, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@aravinsiva
Copy link
Contributor

Currently in Opentelemtry JS there is an instance of configuration for adding default span attributes. The use case for this overlaps heavily with the resource sdk. In addition seems this was just replicated from OpenCensus. Since this is just replicated functionality it is best to remove it.

The implementations can be found here:

@aravinsiva aravinsiva added the bug Something isn't working label Jul 22, 2020
@dyladan
Copy link
Member

dyladan commented Jul 22, 2020

@mayurkale22 do you have any opinion here? I was not around in the OC days or when this was introduced.

My gut feeling is to remove it.

@mayurkale22
Copy link
Member

I believe this field was there in the earlier version of specs. Seems like this concept is not present in other languages, I am fine to remove it.

@dyladan
Copy link
Member

dyladan commented Jul 22, 2020

@aravinsiva are you planning on making a PR or should I mark this as up for grabs?

@aravinsiva
Copy link
Contributor Author

I can go a head and take this on. No problem

@mayurkale22
Copy link
Member

Closed via #1342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants