Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Client for Exporters #190

Closed
hekike opened this issue Aug 10, 2019 · 3 comments
Closed

HTTP Client for Exporters #190

hekike opened this issue Aug 10, 2019 · 3 comments
Labels
Discussion Issue or PR that needs/is extended discussion. feature-request

Comments

@hekike
Copy link
Member

hekike commented Aug 10, 2019

Using the raw Node Core HTTP client comes with some functionality questions.
For example, do we need to consider implementing the followings:

  • Following redirect
  • Configurable timeout
  • Retry logic
  • Authentication / Configurable HTTP headers

Do we want to use a third-party npm library and maybe expose it's configuration to the user or should we go with the built-in http.request and implement these features incrementally based on user requests?

cc @mayurkale22 I think you will face the same questions with the Jaeger exporter.

@draffensperger
Copy link
Contributor

Another question related to this: do we care about the Zipkin exporter working for the web? Typically I would think the exporter story for the web should just be to export to the OpenTelemetry agent and then have it handle actual exporters, but I figured I'd ask.

@mayurkale22
Copy link
Member

Typically I would think the exporter story for the web should just be to export to the OpenTelemetry agent and then have it handle actual exporters.

This makes sense to me and I'd prefer this route.

@danielkhan danielkhan added the Discussion Issue or PR that needs/is extended discussion. label Aug 28, 2019
@danielkhan
Copy link
Contributor

In SIG meeting 2019-08-14 it was concluded that this should be the responsibility of the package.

Closing. Please reopen if you disagree. FYI @hekike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion. feature-request
Projects
None yet
Development

No branches or pull requests

4 participants