-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(exporter-collector): wrong data type for numbers #1938
fix(exporter-collector): wrong data type for numbers #1938
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1938 +/- ##
=======================================
Coverage 92.89% 92.90%
=======================================
Files 152 152
Lines 5914 5922 +8
Branches 1240 1245 +5
=======================================
+ Hits 5494 5502 +8
Misses 420 420
|
ab13881
to
2817149
Compare
6931c64
to
28dcf39
Compare
I think also that the problem here is the backend which seems to take data and just display it. Assume other attributes which are real doubles. They may be sent sometimes as int and sometimes as double now. This may result in similar issues as you see it now - just reversed. |
@Flarna thats why i check also with Number.isInteger which should eliminate problem with 1.32, as this will be send as double |
Consider an attribute Therefore a receiver has to be prepared to get mixed data even with this change and a receiver has to need to convert data in some cases. Anyhow, this shouldn't be seen as blocking. |
maybe use Decimal.js, if value is decimal.js always send as double? |
should i do anything else to have it merged? if it will be merged, can you release fix version 0.17.1 ? |
Which problem is this PR solving?
It corrects data type send to collector
as of now it sends:
and should be:
Short description of the changes
Add way to select intValue in toCollectorAnyValue only for numbers that qualify to range of INT and Number.isInteger()