Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL_EXPORTER_OTLP_HEADERS not honored by gRPC exporter #2303

Closed
1 of 2 tasks
vreynolds opened this issue Jun 28, 2021 · 2 comments · Fixed by #2304
Closed
1 of 2 tasks

OTEL_EXPORTER_OTLP_HEADERS not honored by gRPC exporter #2303

vreynolds opened this issue Jun 28, 2021 · 2 comments · Fixed by #2304
Assignees

Comments

@vreynolds
Copy link
Contributor

  • This only affects the JavaScript OpenTelemetry library
  • This may affect other libraries, but I would like to get opinions here first

I noticed that the gRPC exporter does not honor OTEL_EXPORTER_OTLP_HEADERS (or variants) when setting up metadata, which makes it impossible to configure the gRPC exporter through env vars, if you need authentication metadata.

Based on the spec, I expected that environment variable to apply to the gRPC exporter:

Key-value pairs to be used as headers associated with gRPC or HTTP requests.

Am I misreading the spec, or is this an oversight?

@vmarchaud
Copy link
Member

I believe this is indeed an oversight, i implemented OTEL_EXPORTER_OTLP_HEADERS for http but i don't remember seeing that it was applicable to grpc too. Do you want to tackle this ?

@vreynolds
Copy link
Contributor Author

Yep, I will work on a PR. Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants