Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove metric instrument bind/unbind #2545

Closed
Tracked by #2480
dyladan opened this issue Oct 20, 2021 · 3 comments · Fixed by #2559
Closed
Tracked by #2480

Remove metric instrument bind/unbind #2545

dyladan opened this issue Oct 20, 2021 · 3 comments · Fixed by #2559
Assignees
@legendecas
Labels
feature-request

Comments

@dyladan
Copy link
Member

dyladan commented Oct 20, 2021

The specification has removed the bound instruments from the API.
@dyladan dyladan mentioned this issue Oct 20, 2021
Closed
14 tasks
@dyladan dyladan added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Oct 20, 2021
@legendecas
Copy link
Member

Is there any signal that the bind/unbind was removed intentionally? Like, BatchObserver is not presented in the latest feature-freeze spec, but it is been tracked open-telemetry/opentelemetry-specification#1090 in the feature-feeze project.

@dyladan
Copy link
Member Author

dyladan commented Oct 21, 2021

I'm joining the metrics sig today and I will be sure to ask them

@dyladan dyladan self-assigned this Oct 21, 2021
@dyladan dyladan removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Oct 21, 2021
@legendecas legendecas mentioned this issue Oct 21, 2021
Closed
@dyladan
Copy link
Member Author

dyladan commented Oct 21, 2021

It was intentionally removed and we should remove it unless someone has a very compelling reason not to.

@legendecas legendecas mentioned this issue Oct 22, 2021
Merged
8 tasks
@dyladan dyladan assigned legendecas and unassigned dyladan Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@legendecas legendecas

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api-metrics): remove bind/unbind and bound instruments legendecas/opentelemetry-js
2 participants
@dyladan @legendecas