Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify API compliance of MeterProvider.getMeter #2546

Closed
1 task
Tracked by #2480
dyladan opened this issue Oct 20, 2021 · 0 comments · Fixed by #2563
Closed
1 task
Tracked by #2480

Verify API compliance of MeterProvider.getMeter #2546

dyladan opened this issue Oct 20, 2021 · 0 comments · Fixed by #2563
Assignees
@dyladan
Labels
feature-request

Comments

@dyladan
Copy link
Member

dyladan commented Oct 20, 2021 •
edited
Loading

Ensure our implementation of get meter is compliant with the latest API specification. If not, create a PR to make it compliant.

After looking at spec it seems like the only parameters are name and version. Removing the extra config param is already opened by @legendecas
@dyladan dyladan added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Oct 20, 2021
@dyladan dyladan mentioned this issue Oct 20, 2021
Closed
14 tasks
@legendecas legendecas mentioned this issue Oct 26, 2021
Merged
3 tasks
@dyladan dyladan self-assigned this Oct 27, 2021
@dyladan dyladan removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Oct 27, 2021
@dyladan dyladan linked a pull request Oct 27, 2021 that will close this issue
feat(sdk-metrics-base): remove per-meter config on MeterProvider.getMeter #2563
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyladan dyladan

Labels
feature-request
Projects
None yet
Milestone
No milestone
1 participant
@dyladan