Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky browser test #2852

Closed
legendecas opened this issue Mar 22, 2022 · 3 comments · Fixed by #2969
Closed

Flaky browser test #2852

legendecas opened this issue Mar 22, 2022 · 3 comments · Fixed by #2969
Labels
bug Something isn't working help wanted Extra attention is needed up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@legendecas
Copy link
Member

legendecas commented Mar 22, 2022

I've seen several times of these kinds of random CI failures.

Links:

1) should debug info that injecting headers was skipped
     fetch when request is successful when propagateTraceHeaderCorsUrls does NOT MATCH
     AssertionError: undefined === 'headers inject skipped due to CORS policy'
    at Context.eval (webpack-internal:///./test/fetch.test.ts:385:24)
@legendecas
Copy link
Member Author

legendecas commented Mar 31, 2022

Case 2:

1) should fallback to getEntries
     fetch when PerformanceObserver is undefined
     TypeError: Cannot read properties of undefined (reading '0')
    at Context.eval (webpack-internal:///./test/fetch.test.ts:547:43)

Links:

@dyladan dyladan added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Apr 6, 2022
@pichlermarc
Copy link
Member

Case 3:

1) should create a span with correct root span
     fetch when request is successful
     TypeError: Cannot read properties of undefined (reading '0')
    at Context.eval (webpack-internal:///./test/fetch.test.ts:254:43)

2) should create a span for preflight request
     fetch when request is successful
     TypeError: Cannot read properties of undefined (reading '0')
    at Context.eval (webpack-internal:///./test/fetch.test.ts:295:43)

https://github.com/open-telemetry/opentelemetry-js/runs/5875767862?check_suite_focus=true (main)

I noticed as well that some instrumentation-fetch tests have been failing while working on some of my previous PRs. I hope I have not introduced additional flakiness in the last one (#2871).

@Flarna
Copy link
Member

Flarna commented Apr 8, 2022

We should really aim to get some browser experts into the team. It's not just about flaky tests, also the dependencies (see #2187) to e.g. webpack/karma (and related plugins) are not update since quite a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants