Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous instrument gaps and resets on delta temporality #2987

Closed
Tracked by #2574
legendecas opened this issue May 20, 2022 · 0 comments · Fixed by #2990
Closed
Tracked by #2574

Asynchronous instrument gaps and resets on delta temporality #2987

legendecas opened this issue May 20, 2022 · 0 comments · Fixed by #2990
Assignees
Milestone

Comments

@legendecas
Copy link
Member

legendecas commented May 20, 2022

Spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/supplementary-guidelines.md#asynchronous-example-attribute-removal-in-a-view

We need to detect gaps and resets and prevent producing negative outputs for observable counters aggregated by SumAggregator.

A basic implementation is to add monotonicity support to SumAggregator and perform a conditional diff on SumAggregate.diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants