Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple express app printing odd warning #3304

Closed
legendecas opened this issue Oct 9, 2022 Discussed in #3275 · 2 comments · Fixed by #3308
Closed

Simple express app printing odd warning #3304

legendecas opened this issue Oct 9, 2022 Discussed in #3275 · 2 comments · Fixed by #3308
Labels
bug Something isn't working priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization

Comments

@legendecas
Copy link
Member

legendecas commented Oct 9, 2022 •
edited
Loading

Discussed in #3275

The awb-lambda instrumentation (https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts#L92 ) may not register a module to be instrumented thus the base instrumentation class warns about this: https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts#L52.

Should we remove this warning?
@legendecas legendecas added the bug Something isn't working label Oct 9, 2022
@legendecas legendecas mentioned this issue Oct 10, 2022
Merged
4 tasks
@dyladan dyladan added the priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization label Oct 12, 2022
@dyladan
Copy link
Member

dyladan commented Oct 12, 2022

@legendecas are you planning to work on this or should we put the up for grabs label?

@legendecas
Copy link
Member Author

legendecas commented Oct 13, 2022 •
edited
Loading

#3308 can fix this. The log level is lowered to DEBUG, suggesting informational tips rather than problematic warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization
Projects
None yet
Milestone
No milestone
2 participants
@dyladan @legendecas