Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metric spec review] API not mentioned in the spec but provided by the implementation #3389

Closed
dyladan opened this issue Nov 7, 2022 · 2 comments
Labels
api:metrics Issues and PRs related to the Metrics API
Milestone

Comments

@dyladan
Copy link
Member

dyladan commented Nov 7, 2022

    API not mentioned in the spec but provided by the implementation:

Originally posted by @reyang in open-telemetry/community#1204 (comment)

@dyladan
Copy link
Member Author

dyladan commented Nov 7, 2022

API not mentioned in the spec but provided by the implementation:

This is defined in the spec, with an implementation specialized name: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#multiple-instrument-callbacks. Also, the spec requires the registered callbacks to be able to be unregistered: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#asynchronous-counter-operations.

originally posted by @legendecas

@dyladan dyladan changed the title [metric spec review] 1 [metric spec review] API not mentioned in the spec but provided by the implementation Nov 7, 2022
@dyladan dyladan added this to the Metrics GA milestone Nov 7, 2022
@legendecas legendecas added the api:metrics Issues and PRs related to the Metrics API label Nov 7, 2022
@pichlermarc
Copy link
Member

I think @legendecas' answer addresses the concerns sufficiently. WDYT @open-telemetry/javascript-maintainers? 🤔

@dyladan dyladan closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:metrics Issues and PRs related to the Metrics API
Projects
None yet
Development

No branches or pull requests

3 participants