-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metric spec review] API not mentioned in the spec but provided by the implementation #3389
Comments
This is defined in the spec, with an implementation specialized name: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#multiple-instrument-callbacks. Also, the spec requires the registered callbacks to be able to be unregistered: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#asynchronous-counter-operations. originally posted by @legendecas |
I think @legendecas' answer addresses the concerns sufficiently. WDYT @open-telemetry/javascript-maintainers? 🤔 |
opentelemetry-js/api/src/metrics/Meter.ts
Line 142 in d154066
opentelemetry-js/api/src/metrics/Meter.ts
Line 156 in d154066
Originally posted by @reyang in open-telemetry/community#1204 (comment)
The text was updated successfully, but these errors were encountered: