Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metric spec review] Hide unstable exemplar before release #3393

Closed
dyladan opened this issue Nov 7, 2022 · 4 comments
Closed

[metric spec review] Hide unstable exemplar before release #3393

dyladan opened this issue Nov 7, 2022 · 4 comments
Labels
sdk:metrics Issues and PRs related to the Metrics SDK
Milestone

Comments

@dyladan
Copy link
Member

dyladan commented Nov 7, 2022

    Exemplar in the SDK spec is not yet Stable, need to be removed or hidden if the intention is to ship the initial stable JS package https://github.com/open-telemetry/opentelemetry-js/tree/d154066354863e8c682b4aa488d79c7e914bf91c/experimental/packages/opentelemetry-sdk-metrics/src/exemplar.

Originally posted by @reyang in open-telemetry/community#1204 (comment)

@dyladan
Copy link
Member Author

dyladan commented Nov 7, 2022

Exemplar in the SDK spec is not yet Stable, need to be removed or hidden if the intention is to ship the initial stable JS package https://github.com/open-telemetry/opentelemetry-js/tree/d154066354863e8c682b4aa488d79c7e914bf91c/experimental/packages/opentelemetry-sdk-metrics/src/exemplar.

Exemplar is not exposed in the SDK as a public interface yet: https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-sdk-metrics/src/index.ts.

originally posted by @legendecas

@dyladan dyladan changed the title [metric spec review] 5 [metric spec review] Hide unstable exemplar before release Nov 7, 2022
@dyladan dyladan added this to the Metrics GA milestone Nov 7, 2022
@dyladan
Copy link
Member Author

dyladan commented Nov 7, 2022

@legendecas how would one use unstable exemplar functionality in order to test? Is it possible at all?

@legendecas
Copy link
Member

@dyladan Exemplars are not surfaced in any public APIs (you can try to remove the whole directory https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-sdk-metrics/src/exemplar). So it is not possible to use the unstable exemplar functionality.

@legendecas legendecas added the sdk:metrics Issues and PRs related to the Metrics SDK label Nov 7, 2022
@dyladan
Copy link
Member Author

dyladan commented Nov 8, 2022

@legendecas I think this can be closed then. Please reopen if you disagree

@dyladan dyladan closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk:metrics Issues and PRs related to the Metrics SDK
Projects
None yet
Development

No branches or pull requests

2 participants