-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk-node] automatically configure exporters based on enviornment variables #3871
Comments
Hi, the trace part of this already exists (not specifying any trace exporter or span exporter in code, To add support for env var configuration for logs, we'll first need to tackle #3826 I'm marking this up-for-grabs as metrics is already in a state where this could be implemented 🙂 |
@psk001 sure, go ahead once #3826 is merged. 🙂 Ideally, this function would be internal to the |
Great, waiting for #3969 to get merged 🙂 |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
@psk001 are you still working on the remaining parts of this issue? Otherwise, I'll unassign to indicate that others can pick this up. 🙂 |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
I'll split this into two sub-issues that can be done independently of each-other: |
The last step for this (metrics) was included in the latest feature release (0.57.0) |
Issue I'm facing
The open-telemetry spec defines environment variables that specify which metric / logs / trace reader should be used.
There is currently no way of automatically configuring the instrumentation using these variables.
This is especially useful when using the Kubernetes auto instrumentation.
Describe the solution you'd like
A function that reads the env vars and returns the corresponding metric reader. Maybe
getMetricReaderFromEnv()
.Same thing for logs and traces.
Similar to how we have a
getNodeAutoInstrumentations()
function already.Additional context
This solution was also discussed in a pr in the auto instrumentation project. see: here
The text was updated successfully, but these errors were encountered: