Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IITM to v1.4.1 for Node 20 support #3959

Closed
lizthegrey opened this issue Jul 1, 2023 · 6 comments
Closed

Update IITM to v1.4.1 for Node 20 support #3959

lizthegrey opened this issue Jul 1, 2023 · 6 comments

Comments

@lizthegrey
Copy link
Member

Is your feature request related to a problem? Please describe.

Auto-instrumentation with ESM won't work on Node 20.

Describe the solution you'd like

Upgrade to an IITM build containing nodejs/import-in-the-middle@d07cba2 (for instance, v1.4.0+)

Describe alternatives you've considered

n/a

Additional context

See #3698 for original addition of IITM as a dependency

@pichlermarc
Copy link
Member

I triggered renovate bot to open a PR for it. #3962 🙂
We'll need to do #3774 right after this one though to make sure everything still works as intended.

@lizthegrey
Copy link
Member Author

Cheers, much appreciated.

@lizthegrey
Copy link
Member Author

image

This appears to work!

@trentm
Copy link
Contributor

trentm commented Jul 13, 2023

Note that I opened nodejs/import-in-the-middle#29 when attempting to update to IITM 1.4.1 (for the Elastic agent). I'd appreciate a sanity check on that issue. If I have it right, IITM 1.4.1 can break named imports in ESM files.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 18, 2023
@pichlermarc
Copy link
Member

Closing as completed as we bumped IITM already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants