-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop exporting/using namespaces for string constants such as Semantic conventions and export individual strings. Stop using namespaces #4185
Labels
Milestone
Comments
And yes, as this is an autogenerated file this would be a tooling update, and assuming that we continue to export a Namespaced version (the objects with the strings) this is actually backward compatible. |
MSNev
changed the title
Update Semantic conventions to export individual strings and stop using namespaces within the OTel packages
Stop exporting/using namespaces for string constants such as Semantic conventions and export individual strings. Stop using namespaces
Oct 4, 2023
2 tasks
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This was referenced Jun 15, 2024
This was referenced Jun 21, 2024
This was referenced Jun 22, 2024
This is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One significant minification issues is that for "common" strings such as the SemanticConventions if any single string is "used" then all of the members of the related SemanticConvension namespace also get included in the final bundle.
The suggestion here is to
Example of change
Change from
to
And then internal usages would only reference the
SEMCONV_
constantsI'm not married to the
SEMCONV_
prefix (and a prefix is not actually required), I just included here to avoid confusion and to make it easier to call out the differences.The text was updated successfully, but these errors were encountered: