Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MetricsExporter interface #442

Closed
mayurkale22 opened this issue Oct 18, 2019 · 2 comments · Fixed by #475
Closed

Add MetricsExporter interface #442

mayurkale22 opened this issue Oct 18, 2019 · 2 comments · Fixed by #475
Labels
feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers
Milestone
Alpha v0.3

Comments

@mayurkale22
Copy link
Member

Specs issue : open-telemetry/opentelemetry-specification#157

Similar to SpanExporter interface, add MetricsExporter interface -> An interface that allows different metrics services to export recorded data to the backend.
@mayurkale22 mayurkale22 mentioned this issue Oct 18, 2019
Closed
@mayurkale22 mayurkale22 added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Oct 18, 2019
@zoidyzoidzoid
Copy link

Is this issue and #443 blocked by open-telemetry/opentelemetry-specification#157 ?

@danielkhan
Copy link
Contributor

It's right now implemented here: https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-metrics/src/export/types.ts#L344

shutdown is missing.

@mayurkale22 mayurkale22 added this to the Alpha v0.3 milestone Oct 31, 2019
@mayurkale22 mayurkale22 mentioned this issue Nov 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
Alpha v0.3
Development

Successfully merging a pull request may close this issue.

add shutdown method on MetricExporter interface mayurkale22/opentelemetry-node
3 participants
@zoidyzoidzoid @danielkhan @mayurkale22