-
Notifications
You must be signed in to change notification settings - Fork 952
refactor(otlp-exporter-base): use get*FromEnv() for otlp exporter config #5583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(otlp-exporter-base): use get*FromEnv() for otlp exporter config #5583
Conversation
Migrated away from using `process.env` to use the `getStringFromEnv`-function Signed-off-by: Weyert de Boer <wdb@innerfuse.biz>
…tFromEnv`-functions Signed-off-by: Weyert de Boer <wdb@innerfuse.biz>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5583 +/- ##
==========================================
- Coverage 95.07% 95.07% -0.01%
==========================================
Files 308 308
Lines 8039 8037 -2
Branches 1627 1626 -1
==========================================
- Hits 7643 7641 -2
Misses 396 396
🚀 New features to boost your workflow:
|
Signed-off-by: Weyert de Boer <wdb@innerfuse.biz>
...imental/packages/otlp-exporter-base/test/node/configuration/shared-env-configuration.test.ts
Show resolved
Hide resolved
experimental/packages/otlp-exporter-base/src/configuration/shared-env-configuration.ts
Outdated
Show resolved
Hide resolved
experimental/packages/otlp-exporter-base/src/configuration/shared-env-configuration.ts
Outdated
Show resolved
Hide resolved
...imental/packages/otlp-exporter-base/test/node/configuration/shared-env-configuration.test.ts
Show resolved
Hide resolved
...imental/packages/otlp-exporter-base/test/node/configuration/shared-env-configuration.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Trent Mick <trentm@gmail.com>
pichlermarc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty to address the remaining comments and resolve conflicts. This should be good to merge now.
requested changes were addressed.
Which problem is this PR solving?
Migrated away from using
process.envto use thegetStringFromEnv-functionFixes #5562
Short description of the changes
Replaced the usage of
process.envwith the built-in getEnv utility functionsType of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: