Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Observer and Counter example #868

Closed
Tracked by #2574
mayurkale22 opened this issue Mar 17, 2020 · 3 comments
Closed
Tracked by #2574

Consolidate Observer and Counter example #868

mayurkale22 opened this issue Mar 17, 2020 · 3 comments
Assignees
Labels
Discussion Issue or PR that needs/is extended discussion. document Documentation-related
Milestone

Comments

@mayurkale22
Copy link
Member

I think we should consolidate Observer and Counter example into one. It would be easier to find and comprehend to the end users.

Observer example: https://github.com/open-telemetry/opentelemetry-js/blob/master/examples/metrics/metrics/observer.js

Counter example: https://github.com/open-telemetry/opentelemetry-js/blob/master/examples/prometheus/index.js

@mayurkale22 mayurkale22 added the Discussion Issue or PR that needs/is extended discussion. label Mar 17, 2020
@mayurkale22 mayurkale22 added this to the After Beta Release milestone Mar 18, 2020
@smith
Copy link

smith commented Apr 29, 2022

The "Observer example" linked above is a 404; it may of been moved but I'm pretty sure it now refers to https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-sdk-metrics-base/examples/metrics/metrics/observer.js.

@legendecas
Copy link
Member

The observer API is still experimental. It is likely going to be improved before the GA of the metrics SDK. I'll keep track of this at #2574

@dyladan
Copy link
Member

dyladan commented Jul 25, 2022

The observer example was removed in the rewrite. I'm closing this since I feel it is covered by #3026

@dyladan dyladan closed this as completed Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion. document Documentation-related
Projects
None yet
Development

No branches or pull requests

4 participants