-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inject env begining with prefix "OTEL_" #706
Comments
The main reason that the operator uses only Which env vars would you like to inject? It seems that the SPLUNK agent supports both
I like the idea that the operator could work with vendor distributions. In this case we could support |
Thanks for the quick reply, here's all the envs for splunk otel java lib we could configure, https://docs.splunk.com/observability/gdi/get-data-in/application/java/configuration/advanced-java-otel-configuration.html#nav-Advanced-configuration.
And yes SPlunk distributed java library supports all the features of the OpenTelemetry Instrumentation for Java and added extra features as the link mentioned here https://docs.splunk.com/observability/gdi/get-data-in/application/java/splunk-java-otel-distribution.html#features-of-the-splunk-distribution-of-opentelemetry-java, thay may explain it supports OTEL and SPLUNK prefix. |
@elvis-cai would you like to submit a PR to fix this? |
sure. |
Hi
we are using otel operator to inject splunk otel java library, and from the doc https://docs.splunk.com/observability/gdi/get-data-in/application/java/instrumentation/instrument-java-application.html#deploy-the-java-agent-in-kubernetes, we also need inject env starting with prefix SPLUNK_, and from the code https://github.com/open-telemetry/opentelemetry-operator/blob/main/apis/v1alpha1/instrumentation_webhook.go#L134 it is hardcoded to OTEL, just wondering is it possible we could inject env other than OTEL_ to make operator more generic? thanks.
The text was updated successfully, but these errors were encountered: