Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determining the Parent Span from a Context - should conform to latest OTel spec #239

Closed
jodeev opened this issue Jan 14, 2021 · 0 comments · Fixed by #422
Closed

Determining the Parent Span from a Context - should conform to latest OTel spec #239

jodeev opened this issue Jan 14, 2021 · 0 comments · Fixed by #422
Labels
bug Something isn't working good first issue Good for newcomers help wanted This issue is looking for someone to work on it medium medium sized task

Comments

@jodeev
Copy link
Contributor

jodeev commented Jan 14, 2021

It seems that the linking between the Context/SpanContext/Span is not implemented properly.

The OpenTelemetry spec says that the SpanContext should be encapsulated inside the Span, but the Tracer is able to create a new Span with a specific SpanContext, created outside of the Span.

For example TraceContext::extract returns a SpanContext and Tracer::startAndActivateSpanFromContext receives SpanContext as parameter.

We should follow the spec for the implementation.
@jodeev jodeev added bug Something isn't working release:required-for-ga labels Jan 14, 2021
@bobstrecansky bobstrecansky added the good first issue Good for newcomers label Jun 9, 2021
@bobstrecansky bobstrecansky added help wanted This issue is looking for someone to work on it release:required-for-beta medium medium sized task labels Aug 5, 2021
@Blacksmoke16 Blacksmoke16 mentioned this issue Sep 12, 2021
Merged
4 tasks
@Blacksmoke16 Blacksmoke16 mentioned this issue Sep 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted This issue is looking for someone to work on it medium medium sized task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Span Refactor Blacksmoke16/opentelemetry-php
2 participants
@bobstrecansky @jodeev