Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] php 8.2 support #826

Closed
5 of 6 tasks
brettmc opened this issue Sep 16, 2022 · 6 comments
Closed
5 of 6 tasks

[META] php 8.2 support #826

brettmc opened this issue Sep 16, 2022 · 6 comments
Labels
php8.2 PHP 8.2 related

Comments

@brettmc
Copy link
Collaborator

brettmc commented Sep 16, 2022

Issues to be resolved to enable opentelemetry-php to work with php 8.2:

@brettmc brettmc added bug Something isn't working php8.2 PHP 8.2 related labels Sep 16, 2022
@brettmc brettmc pinned this issue Sep 16, 2022
@bobstrecansky
Copy link
Collaborator

All the PRs are in for this, we are just waiting on Google support. I'm going to follow up with them.

@brettmc brettmc removed the bug Something isn't working label Oct 12, 2022
@bobstrecansky
Copy link
Collaborator

I've bumped our Google support rep today; waiting to hear back from them.

@brettmc
Copy link
Collaborator Author

brettmc commented Oct 26, 2022

gRPC and protobuf PRs have been merged, now to wait for them to be included in releases.

@bobstrecansky
Copy link
Collaborator

I'm going to ping our google rep about a release of https://github.com/protocolbuffers/protobuf

@brettmc
Copy link
Collaborator Author

brettmc commented Nov 30, 2022

22.10 was released a couple of hours ago (coincidence?) but it doesn't include my changes.

Since the issue only affects the native php protobuf implementation (which we discourage using in favour of the extension), I'm ok with just calling this done.

@brettmc
Copy link
Collaborator Author

brettmc commented Dec 21, 2022

I'm going to close this, since the only outstanding issue (protobuf) shouldn't affect us (since we strongly encourage using the extension).
One last thing to note, is that php-cs-fixer isn't certified against 8.2, and until it is make style will complain.

@brettmc brettmc closed this as completed Dec 21, 2022
@brettmc brettmc unpinned this issue Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php8.2 PHP 8.2 related
Projects
None yet
Development

No branches or pull requests

2 participants