Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contrib] update symfony sdk bundle to work with otel beta/GA #901

Closed
brettmc opened this issue Dec 15, 2022 · 5 comments
Closed

[contrib] update symfony sdk bundle to work with otel beta/GA #901

brettmc opened this issue Dec 15, 2022 · 5 comments
Labels
bug Something isn't working help wanted This issue is looking for someone to work on it medium medium sized task nice-to-have a nice to have thing! opentelemetry-php-contrib This issue is related to the opentelemetry-php-contrib repository

Comments

@brettmc
Copy link
Collaborator

brettmc commented Dec 15, 2022

The Symfony SDK Bundle needs some work to make it compatible with opentelemetry-php beta.

For the time being, its composer dependencies have been pinned to 0.0.15, which is the latest pre-release version that it successfully builds against.

Steps to reproduce

  • update composer.json, "open-telemetry/opentelemetry": "^1"
  • PHP_VERSION=8.1 PROJECT=Symfony make all
@brettmc brettmc added bug Something isn't working help wanted This issue is looking for someone to work on it medium medium sized task opentelemetry-php-contrib This issue is related to the opentelemetry-php-contrib repository nice-to-have a nice to have thing! labels Dec 15, 2022
@bobstrecansky
Copy link
Collaborator

@anthonyptetlow, do you have any insight here?

@anthonyptetlow
Copy link

So I had tried to get it up and running with version 1 when I first looked into it and couldn't at that point as a lot seemed to have changed. Hoever that was when I was first digging into the otel stuff so likely have a much better handle on it now so when I get some spare time I'll take another look.

@wadjei
Copy link

wadjei commented Jun 16, 2023

@brettmc I've been continuing to work with this package and believe I have something compatible with the current open-telemetry/contrib-symfony-instrumentation-bundle library.

Does opentelemetry-php/contrib-sdk-bundle#2 work for you?

@brettmc
Copy link
Collaborator Author

brettmc commented Jun 18, 2023

I left a couple of comments on that PR, but you'll need to resubmit it against the contrib repo.

@brettmc
Copy link
Collaborator Author

brettmc commented Aug 9, 2023

@brettmc brettmc closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted This issue is looking for someone to work on it medium medium sized task nice-to-have a nice to have thing! opentelemetry-php-contrib This issue is related to the opentelemetry-php-contrib repository
Projects
None yet
Development

No branches or pull requests

4 participants