Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper version of go in go.mod #195

Closed
pellared opened this issue Nov 26, 2024 · 0 comments · Fixed by #205
Closed

Improper version of go in go.mod #195

pellared opened this issue Nov 26, 2024 · 0 comments · Fixed by #205
Labels
bug Something isn't working

Comments

@pellared
Copy link
Member

Currently the otlp/go.mod has:

Notice that the Go module depends on:

google.golang.org/grpc v1.67.1

Which requires Go 1.21: https://github.com/grpc/grpc-go/blob/v1.67.1/go.mod#L3

Therefore, in otlp/go.mod we should have go 1.21.

It look like that there is no GitHub workflows that tests if the generated code actually builds.

I think that renovate (instead of dependabot) would be able to bump the Go version.

Bug found when reviewing #194 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant