Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary of attribute names #12

Closed
SergeyKanzhelev opened this issue May 31, 2019 · 7 comments
Closed

Dictionary of attribute names #12

SergeyKanzhelev opened this issue May 31, 2019 · 7 comments
Assignees

Comments

@SergeyKanzhelev
Copy link
Member

Will we need at some point a dictionary of standard attribute names and use indexes instead of names for the attributes collection? It may save a lot of bandwidth, but will require to change the type for now from string to AttributeKey.

@jmacd
Copy link
Contributor

jmacd commented Jun 26, 2019

I think we should compare and contrast with a good compression library? Compression is cheap and will avoid the need for this sort of complexity.

@SergeyKanzhelev
Copy link
Member Author

do you know if there is compression in grpc/proto?

@bogdandrutu
Copy link
Member

@SergeyKanzhelev yes. You can use gzip and few other options.

@SergeyKanzhelev
Copy link
Member Author

@tigrannajaryan are we using compression in our protocol? What do you think about this issues? I'm happy to close it if we have some note on how to gzip or why we do not want to gzip

@SergeyKanzhelev
Copy link
Member Author

@tigrannajaryan assigning to you if you don't mind

@tigrannajaryan
Copy link
Member

@SergeyKanzhelev thanks. I addressed this in open-telemetry/oteps#59
Once that is approved I will update Span proto definition in this repo.

@tigrannajaryan
Copy link
Member

Regarding compression: OTLP uses gRPC and compression is supported out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants