Skip to content

Commit 34475e1

Browse files
committed
Merge branch 'main' into audit-and-test-opentelemetry-instrumentation-elasticsearch-no-op-tracer
2 parents c0e3774 + 5e4766e commit 34475e1

File tree

32 files changed

+414
-125
lines changed

32 files changed

+414
-125
lines changed

.github/workflows/backport.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
env:
2929
NUMBER: ${{ github.event.inputs.number }}
3030
# not using secrets.GITHUB_TOKEN since pull requests from that token do not run workflows
31-
GITHUB_TOKEN: ${{ secrets.BOT_TOKEN }}
31+
GITHUB_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }}
3232
run: |
3333
commit=$(gh pr view $NUMBER --json mergeCommit --jq .mergeCommit.oid)
3434
title=$(gh pr view $NUMBER --json title --jq .title)

.github/workflows/prepare-patch-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969
- name: Create pull request
7070
env:
7171
# not using secrets.GITHUB_TOKEN since pull requests from that token do not run workflows
72-
GITHUB_TOKEN: ${{ secrets.BOT_TOKEN }}
72+
GITHUB_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }}
7373
run: |
7474
message="Prepare release ${STABLE_VERSION}/${UNSTABLE_VERSION}"
7575
branch="opentelemetrybot/prepare-release-${STABLE_VERSION}-${UNSTABLE_VERSION}"

.github/workflows/prepare-release-branch.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ jobs:
9696
- name: Create pull request against the release branch
9797
env:
9898
# not using secrets.GITHUB_TOKEN since pull requests from that token do not run workflows
99-
GITHUB_TOKEN: ${{ secrets.BOT_TOKEN }}
99+
GITHUB_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }}
100100
run: |
101101
message="Prepare release ${STABLE_VERSION}/${UNSTABLE_VERSION}"
102102
branch="opentelemetrybot/prepare-release-${STABLE_VERSION}-${UNSTABLE_VERSION}"
@@ -181,7 +181,7 @@ jobs:
181181
- name: Create pull request against main
182182
env:
183183
# not using secrets.GITHUB_TOKEN since pull requests from that token do not run workflows
184-
GITHUB_TOKEN: ${{ secrets.BOT_TOKEN }}
184+
GITHUB_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }}
185185
run: |
186186
message="Update version to ${STABLE_NEXT_VERSION}/${UNSTABLE_NEXT_VERSION}"
187187
body="Update version to \`${STABLE_NEXT_VERSION}/${UNSTABLE_NEXT_VERSION}\`."

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ jobs:
184184
- name: Create pull request against main
185185
env:
186186
# not using secrets.GITHUB_TOKEN since pull requests from that token do not run workflows
187-
GITHUB_TOKEN: ${{ secrets.BOT_TOKEN }}
187+
GITHUB_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }}
188188
run: |
189189
message="Copy change log updates from $GITHUB_REF_NAME"
190190
body="Copy log updates from \`$GITHUB_REF_NAME\`."

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
99

1010
### Added
1111

12+
- Support `aio_pika` 9.x (([#1670](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1670])
1213
- `opentelemetry-instrumentation-redis` Add `sanitize_query` config option to allow query sanitization. ([#1572](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1572))
14+
- `opentelemetry-instrumentation-elasticsearch` Add optional db.statement query sanitization.
15+
([#1598](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1598))
1316
- `opentelemetry-instrumentation-celery` Record exceptions as events on the span.
1417
([#1573](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1573))
1518
- Add metric instrumentation for urllib
@@ -27,6 +30,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2730

2831
### Fixed
2932

33+
- Fix TortoiseORM instrumentation `AttributeError: type object 'Config' has no attribute 'title'`
34+
([#1575](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1575))
3035
- Fix SQLAlchemy uninstrumentation
3136
([#1581](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1581))
3237
- `opentelemetry-instrumentation-grpc` Fix code()/details() of _OpentelemetryServicerContext.
@@ -42,6 +47,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
4247
([#1435](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1435))
4348
- mongo db - fix db statement capturing
4449
([#1512](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1512))
50+
- Add commit method for ConfluentKafkaInstrumentor's ProxiedConsumer
51+
([#1656](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1656))
4552

4653
## Version 1.15.0/0.36b0 (2022-12-10)
4754

instrumentation/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
| Instrumentation | Supported Packages | Metrics support |
33
| --------------- | ------------------ | --------------- |
4-
| [opentelemetry-instrumentation-aio-pika](./opentelemetry-instrumentation-aio-pika) | aio_pika >= 7.2.0, < 9.0.0 | No
4+
| [opentelemetry-instrumentation-aio-pika](./opentelemetry-instrumentation-aio-pika) | aio_pika >= 7.2.0, < 10.0.0 | No
55
| [opentelemetry-instrumentation-aiohttp-client](./opentelemetry-instrumentation-aiohttp-client) | aiohttp ~= 3.0 | No
66
| [opentelemetry-instrumentation-aiopg](./opentelemetry-instrumentation-aiopg) | aiopg >= 0.13.0, < 2.0.0 | No
77
| [opentelemetry-instrumentation-asgi](./opentelemetry-instrumentation-asgi) | asgiref ~= 3.0 | No
@@ -16,7 +16,7 @@
1616
| [opentelemetry-instrumentation-django](./opentelemetry-instrumentation-django) | django >= 1.10 | Yes
1717
| [opentelemetry-instrumentation-elasticsearch](./opentelemetry-instrumentation-elasticsearch) | elasticsearch >= 2.0 | No
1818
| [opentelemetry-instrumentation-falcon](./opentelemetry-instrumentation-falcon) | falcon >= 1.4.1, < 4.0.0 | Yes
19-
| [opentelemetry-instrumentation-fastapi](./opentelemetry-instrumentation-fastapi) | fastapi ~= 0.58 | Yes
19+
| [opentelemetry-instrumentation-fastapi](./opentelemetry-instrumentation-fastapi) | fastapi <= 0.90.1 | Yes
2020
| [opentelemetry-instrumentation-flask](./opentelemetry-instrumentation-flask) | flask >= 1.0, < 3.0 | Yes
2121
| [opentelemetry-instrumentation-grpc](./opentelemetry-instrumentation-grpc) | grpcio ~= 1.27 | No
2222
| [opentelemetry-instrumentation-httpx](./opentelemetry-instrumentation-httpx) | httpx >= 0.18.0 | No

instrumentation/opentelemetry-instrumentation-aio-pika/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ dependencies = [
3131

3232
[project.optional-dependencies]
3333
instruments = [
34-
"aio_pika >= 7.2.0, < 9.0.0",
34+
"aio_pika >= 7.2.0, < 10.0.0",
3535
]
3636
test = [
3737
"opentelemetry-instrumentation-aio-pika[instruments]",

instrumentation/opentelemetry-instrumentation-aio-pika/src/opentelemetry/instrumentation/aio_pika/package.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@
1313
# limitations under the License.
1414
from typing import Collection
1515

16-
_instruments: Collection[str] = ("aio_pika >= 7.2.0, < 9.0.0",)
16+
_instruments: Collection[str] = ("aio_pika >= 7.2.0, < 10.0.0",)

instrumentation/opentelemetry-instrumentation-aio-pika/tests/consts.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
from argparse import Namespace
22

3+
from aio_pika import __version__ as aiopika_version
34
from yarl import URL
45

6+
AIOPIKA_VERSION_INFO = tuple(int(v) for v in aiopika_version.split("."))
57
MESSAGE_ID = "meesage_id"
68
CORRELATION_ID = "correlation_id"
79
MESSAGING_SYSTEM = "rabbitmq"

instrumentation/opentelemetry-instrumentation-aio-pika/tests/test_callback_decorator.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import asyncio
1515
from unittest import TestCase, mock, skipIf
1616

17-
from aio_pika import Queue, version_info
17+
from aio_pika import Queue
1818

1919
from opentelemetry.instrumentation.aio_pika.callback_decorator import (
2020
CallbackDecorator,
@@ -23,6 +23,7 @@
2323
from opentelemetry.trace import SpanKind, get_tracer
2424

2525
from .consts import (
26+
AIOPIKA_VERSION_INFO,
2627
CHANNEL_7,
2728
CHANNEL_8,
2829
CORRELATION_ID,
@@ -36,7 +37,7 @@
3637
)
3738

3839

39-
@skipIf(version_info >= (8, 0), "Only for aio_pika 7")
40+
@skipIf(AIOPIKA_VERSION_INFO >= (8, 0), "Only for aio_pika 7")
4041
class TestInstrumentedQueueAioRmq7(TestCase):
4142
EXPECTED_ATTRIBUTES = {
4243
SpanAttributes.MESSAGING_SYSTEM: MESSAGING_SYSTEM,
@@ -76,7 +77,7 @@ def test_decorate_callback(self):
7677
callback.assert_called_once_with(MESSAGE)
7778

7879

79-
@skipIf(version_info <= (8, 0), "Only for aio_pika 8")
80+
@skipIf(AIOPIKA_VERSION_INFO <= (8, 0), "Only for aio_pika 8")
8081
class TestInstrumentedQueueAioRmq8(TestCase):
8182
EXPECTED_ATTRIBUTES = {
8283
SpanAttributes.MESSAGING_SYSTEM: MESSAGING_SYSTEM,

0 commit comments

Comments
 (0)