Add db.system attribute

Author: bschoenmaeckers

instrumentation/opentelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py

@@ -95,6 +95,7 @@ def _wrap_connect_internal(func, module, args, kwargs):
             if span.is_recording():
                 attrs, _ = _get_attributes_from_url(module.url)
                 span.set_attributes(attrs)
+                span.set_attribute(SpanAttributes.DB_SYSTEM, _normalize_vendor(module.name))
             return func(*args, **kwargs)
 
     return _wrap_connect_internal

instrumentation/opentelemetry-instrumentation-sqlalchemy/tests/test_sqlalchemy.py

@@ -162,6 +162,7 @@ def test_create_engine_wrapper(self):
         # first span - the connection to the db
         self.assertEqual(spans[0].name, "connect")
         self.assertEqual(spans[0].attributes[SpanAttributes.DB_NAME], ":memory:")
+        self.assertEqual(spans[0].attributes[SpanAttributes.DB_SYSTEM], "sqlite")
         self.assertEqual(spans[0].kind, trace.SpanKind.CLIENT)
         # second span - the query
         self.assertEqual(spans[1].name, "SELECT :memory:")
@@ -221,6 +222,7 @@ async def run():
             # first span - the connection to the db
             self.assertEqual(spans[0].name, "connect")
             self.assertEqual(spans[0].attributes[SpanAttributes.DB_NAME], ":memory:")
+            self.assertEqual(spans[0].attributes[SpanAttributes.DB_SYSTEM], "sqlite")
             self.assertEqual(spans[0].kind, trace.SpanKind.CLIENT)
             # second span - the query
             self.assertEqual(spans[1].name, "SELECT :memory:")