Add span for connection phase

Author: shahargl

instrumentation/opentelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/__init__.py

@@ -63,6 +63,7 @@
     _get_tracer,
     _wrap_create_async_engine,
     _wrap_create_engine,
+    _wrap_connect,
 )
 from opentelemetry.instrumentation.sqlalchemy.package import _instruments
 from opentelemetry.instrumentation.utils import unwrap
@@ -101,7 +102,11 @@ def _instrument(self, **kwargs):
                 "create_async_engine",
                 _wrap_create_async_engine(tracer_provider),
             )
-
+        _w(
+            "sqlalchemy.engine.base",
+            "Engine.connect",
+            _wrap_connect(tracer_provider)
+        )
         if kwargs.get("engine") is not None:
             return EngineTracer(
                 _get_tracer(tracer_provider),

instrumentation/opentelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py

@@ -77,6 +77,17 @@ def _wrap_create_engine_internal(func, module, args, kwargs):
     return _wrap_create_engine_internal
 
 
+def _wrap_connect(tracer_provider=None):
+    def _wrap_connect_internal(func, module, args, kwargs):
+        tracer = trace.get_tracer(
+            module.name,
+            __version__,
+            tracer_provider=tracer_provider,
+        )
+        with tracer.start_as_current_span("database-connect") as span:
+            return func(*args, **kwargs)
+    return _wrap_connect_internal
+
 class EngineTracer:
     def __init__(self, tracer, engine, enable_commenter=False):
         self.tracer = tracer