Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tornado tests assume metric data_points implement Iterator #1455

Closed
lancetarn opened this issue Nov 17, 2022 · 0 comments · Fixed by #1456
Closed

Tornado tests assume metric data_points implement Iterator #1455

lancetarn opened this issue Nov 17, 2022 · 0 comments · Fixed by #1456
Labels
bug Something isn't working

Comments

@lancetarn
Copy link
Contributor

This is related to

The SDK defines data_points as (at most) an Iterable, not an Iterator. The related PR will convert them to a Sequence, which matches a consumer's type definition and will avoid holding a lock in an unrealized generator.

Steps to reproduce
See https://github.com/open-telemetry/opentelemetry-python/actions/runs/3482444373/jobs/5842457813#step:7:8461

What is the expected behavior?
Tests should pass

What is the actual behavior?
Tests fail due to next call on unsupported type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant