Skip to content

Drop unneeded requirements from tornado test-requirements #3173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xrmx opened this issue Jan 7, 2025 · 4 comments · Fixed by #3411
Closed

Drop unneeded requirements from tornado test-requirements #3173

xrmx opened this issue Jan 7, 2025 · 4 comments · Fixed by #3411
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@xrmx
Copy link
Contributor

xrmx commented Jan 7, 2025

Describe your environment

OS: (e.g, Ubuntu)
Python version: (e.g., Python 3.8.10)
Package version: (e.g., 0.46.0)

What happened?

Double check that the following libraries are required in tornado test-requirements:

blinker==1.7.0
Flask==3.0.2
itsdangerous==2.1.2
Jinja2==3.1.4
MarkupSafe==2.1.2
Werkzeug==3.0.6

Looks like they have been copied from a flask test-requirements file.

Steps to Reproduce

Look at tornado instrumentation test-requirements.txt

Expected Result

No flask related library present

Actual Result

Flask related libraries are there

Additional context

No response

Would you like to implement a fix?

No

@xrmx xrmx added bug Something isn't working good first issue Good for newcomers labels Jan 7, 2025
@rahulhacker
Copy link
Contributor

@xrmx : Can you please assign this to me??

@xrmx
Copy link
Contributor Author

xrmx commented Mar 25, 2025

@rahulhacker When you have time to work on this just add a comment here and we'll consider this assigned to you for a week.

@rahulhacker
Copy link
Contributor

@xrmx : sure thanks for the response

@rahulhacker
Copy link
Contributor

@xrmx :
All these libraries belongs to the flask, but let me run the test cases after removing it.
Once confirmed will raise the PR

  1. blinker: A library for creating signals, often used in Flask for event handling.
  2. Flask: A lightweight WSGI web framework, unrelated to Tornado.
  3. itsdangerous: A library for securely signing data, used internally by Flask.
  4. Jinja2: A templating engine used by Flask for rendering HTML templates.
  5. MarkupSafe: A library for escaping text in templates, used by Jinja2.
  6. Werkzeug: A WSGI utility library, used as the foundation of Flask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
2 participants