Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test our docs #4001

Open
ocelotl opened this issue Jun 27, 2024 · 4 comments
Open

Test our docs #4001

ocelotl opened this issue Jun 27, 2024 · 4 comments
Labels
doc Documentation-related good first issue Good first issue help wanted

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jun 27, 2024

Describe your environment

OS: (e.g, Ubuntu)
Python version: (e.g., Python 3.8.10)
SDK version: (e.g., 1.25.0)
API version: (e.g., 1.25.0)

What happened?

Nothing

Steps to Reproduce

We should add tests for our docs. Just testing that we can run the example in CI will do.

Expected Result

Doc tests running in CI

Actual Result

No tests running in CI

Additional context

No response

Would you like to implement a fix?

None

@ocelotl ocelotl added the doc Documentation-related label Jun 27, 2024
@zhihali
Copy link
Contributor

zhihali commented Jun 28, 2024

Hi, I would like to try this one. But I didn't have a chance do documentation testing before. Is there any specific guidance or constraints I should be aware of before I start working on this? Thanks!

@emdneto
Copy link
Member

emdneto commented Jun 28, 2024

@Charlie-lizhihan I would start by looking at what we have right now here: https://github.com/open-telemetry/opentelemetry-python/tree/main/docs/getting_started and include those tests as part of CI.

@zhihali
Copy link
Contributor

zhihali commented Jul 1, 2024

@emdneto Thank you so much!

@pmcollins
Copy link
Member

Shameless plug, but I wrote oteltest for this purpose.

It lets you run example scripts or integration tests, with all configuration and logic co-located within each script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation-related good first issue Good first issue help wanted
Projects
None yet
Development

No branches or pull requests

4 participants