Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore renaming/enhancing opentelemetry-helpers-sql-obfuscation gem #1194

Open
hannahramadan opened this issue Oct 14, 2024 · 2 comments
Open
Labels
keep Ensures stale-bot keeps this issue/PR open

Comments

@hannahramadan
Copy link
Contributor

Currently, the opentelemetry-helpers-sql-obfuscation gem contains the logic for SQL sanitation; the name of this gem reflects this. However, there are additional instances where shared logic would be helpful for db instrumentations.

This idea came up in context of adding a new attribute to db spans, where currently logic is duplicated across db instrumentations to parse SQL statements for the db collection/table name and add it to a span [context].

We should consider what it takes to rename the obfuscation gem to something more broad, such as sql-processor, and refactoring shared logic in db instrumentations to make use of this gem.

@scbjans
Copy link
Contributor

scbjans commented Nov 6, 2024

hi @hannahramadan,
previously we did something similar with the resource detectors:

  1. create the new gem, add to CI etc.
  2. update the old gem, setting a post_install_message stating the old gem is deprecated and point users to the new gem (e.g. refactor: split resource_detectors into their own gems. #639 )
  3. update codebase to make sure new gem is used
  4. clean up (e.g Remove opentelemetry-resource_detectors all-in-one gem #659 )

Copy link
Contributor

github-actions bot commented Dec 7, 2024

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Dec 7, 2024
@arielvalentin arielvalentin added keep Ensures stale-bot keeps this issue/PR open and removed stale Marks an issue/PR stale labels Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep Ensures stale-bot keeps this issue/PR open
Projects
None yet
Development

No branches or pull requests

3 participants