-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS EC2 resource autodetection #20
Comments
I'm Ruby noob but will be happy to learn something and help with that. |
Thanks @rydzykje - I've assigned this to you. |
I did a little research into this ticket, and I wanted to get some clarification before trying anything silly. Please forgive any naivete, as I'm new to Open Telemetry! So this ticket differs from sibling GCP implementation in open-telemetry/opentelemetry-ruby#263 because Google Cloud provides a lovely Ruby gem that gives a lot of the data that the specification wants. As far as I can tell, there's no AWS equivalent to that GCP gem (would love to be wrong about this, though!). As a workaround, the JS EC2 detector hits the instance identity document endpoint to fill out the details of the resource. This investigation makes me wonder a couple things:
|
This issue is specifically about EC2, but we'd be happy to see contributions around any of those environments. If it's a ton of work to support all the environments, then delivering them one at a time is probably better, but otherwise a single PR covering all of them would be fine.
We're planning to refactor the resource detectors gem to extract the GCP support to a separate gem. Other detectors should also be separate gems. That will allow users to only require the detectors for the environments they use and not suffer the performance penalty from other detectors. |
Ah, wonderful! Thanks so much for the clarification. I'll try to start with EC2 and see where it leads. |
Follow on from open-telemetry/opentelemetry-ruby#230 and open-telemetry/opentelemetry-ruby#263.
The text was updated successfully, but these errors were encountered: