Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to add attributes to "instrumentation scope"? #1262

Closed
tigrannajaryan opened this issue May 17, 2022 · 3 comments
Closed

Is it possible to add attributes to "instrumentation scope"? #1262

tigrannajaryan opened this issue May 17, 2022 · 3 comments

Comments

@tigrannajaryan
Copy link
Member

This OTEP proposed to add attributes to instrumentation scope.

This issue is a question for the maintainers of this repo: are we able to do this in a non-breaking manner and without significant performance impact?

@ahayworth
Copy link
Contributor

I think that it's likely possible, yes - if I understand that OTEP correctly, the attributes would be added to the instrumentation scope when obtaining a tracer. Since that happens infrequently, I suspect it will not be a huge problem.

However, if any other @open-telemetry/ruby-approvers or @open-telemetry/ruby-maintainers want to chime in, that would be excellent.

@fbogsany
Copy link
Contributor

We would need to add an optional parameter to the API here:

def tracer(name = nil, version = nil)
and to the SDK here:
def tracer(name = nil, version = nil)

The SDK Tracer initializer is marked API-private, so any changes there are backwards compatible. We will need to add the attributes to Scope (which is still InstrumentationLibrary for us), but that will be backwards compatible as well.

@tigrannajaryan
Copy link
Member Author

Thank you @ahayworth @fbogsany
I will close this, since all I needed for now was a confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants