Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: should Resource initialization use env vars only? #99

Closed
fbogsany opened this issue Sep 19, 2019 · 2 comments
Closed

SDK: should Resource initialization use env vars only? #99

fbogsany opened this issue Sep 19, 2019 · 2 comments
Labels
question Further information is requested
Milestone

Comments

@fbogsany
Copy link
Contributor

#86 (comment):

In the java SDK the resource is final: https://github.com/open-telemetry/opentelemetry-java/blob/master/sdk/src/main/java/io/opentelemetry/sdk/trace/TracerSdk.java#L50 and assigned as an EnvVarResource, which we don't yet have. We could consider doing the same and turn this into a reader.

Should we allow manual configuration of Resource or should it be entirely automatic based on environment variables, like the Java SDK?

@fbogsany fbogsany added this to the Alpha milestone Sep 23, 2019
@fbogsany fbogsany added the question Further information is requested label Sep 23, 2019
@fbogsany fbogsany modified the milestones: Alpha v0.2, Alpha v0.3 Oct 25, 2019
@fbogsany fbogsany modified the milestones: Alpha v0.3, Alpha v0.4 Mar 12, 2020
@fbogsany
Copy link
Contributor Author

Bump. Is this still relevant or is this resolved by #263?

@fbogsany
Copy link
Contributor Author

fbogsany commented Jul 2, 2020

open-telemetry/oteps#111 will clarify this. At present, we support setting this in a couple different ways, which is probably correct. This may change -- we will revisit it when OTEP 111 is resolved.

@fbogsany fbogsany closed this as completed Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant