Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make B3 propagator fully support spec #147

Closed
jtescher opened this issue Jul 11, 2020 · 3 comments · Fixed by #148
Closed

Make B3 propagator fully support spec #147

jtescher opened this issue Jul 11, 2020 · 3 comments · Fixed by #148
Labels
good first issue Good for newcomers

Comments

@jtescher
Copy link
Member

The existing implementation of the B3 propagator does not fully implement the HTTP B3 specification.

Full B3 Specification: https://github.com/openzipkin/b3-propagation

See similar PR in go impl for needed changes: open-telemetry/opentelemetry-go#882
@jtescher jtescher added the good first issue Good for newcomers label Jul 11, 2020
@TommyCpp
Copy link
Contributor

If no one is currently working on this one. I'd like to give it a try.

@jtescher
Copy link
Member Author

@TommyCpp sounds good! happy to answer questions as you work through it, hopefully the referenced go changes are useful as well.

@TommyCpp
Copy link
Contributor

@jtescher Thanks! I think I finished most of the changes but may still need some time to double check with go implementation to make sure I got all test case covered, after that I should have a PR for review.

@TommyCpp TommyCpp mentioned this issue Jul 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[b3_propagator] Follow the b3 spec TommyCpp/opentelemetry-rust
2 participants
@jtescher @TommyCpp