Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CI tests are failing during grpc-build #1656

Closed
lalitb opened this issue Apr 5, 2024 · 1 comment · Fixed by #1658
Closed

[Bug]: CI tests are failing during grpc-build #1656

lalitb opened this issue Apr 5, 2024 · 1 comment · Fixed by #1658
Labels
bug Something isn't working triage:todo Needs to be traiged.

Comments

@lalitb
Copy link
Member

lalitb commented Apr 5, 2024

What happened?

Error:

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/integration_test.rs (target/debug/deps/integration_test-07b263362dfe3560)

running 3 tests
test duplicate_metrics ... ok
test multiple_scopes ... ok
test prometheus_exporter_integration ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

     Running unittests src/lib.rs (target/debug/deps/opentelemetry_proto-a4fc5d2fabd1ea4f)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/grpc_build.rs (target/debug/deps/grpc_build-38b445f54f67a829)

running 1 test
test build_tonic ... FAILED

failures:

---- build_tonic stdout ----
cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/common/v1/common.proto
cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/resource/v1/resource.proto
cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/trace/v1/trace.proto
cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/collector/trace/v1/trace_service.proto
cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/metrics/v1/metrics.proto
cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/collector/metrics/v1/metrics_service.proto
cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/logs/v1/logs.proto
cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/collector/logs/v1/logs_service.proto
cargo:rerun-if-changed=src/proto/tracez.proto
cargo:rerun-if-changed=src/proto/opentelemetry-proto
cargo:rerun-if-changed=src/proto
thread 'build_tonic' panicked at opentelemetry-proto/tests/grpc_build.rs:116:9:
generated file has changed but it's a CI environment, please rerun this test locally and commit the changes
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    build_tonic

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.12s

error: test failed, to rerun pass `-p opentelemetry-proto --test grpc_build`

API Version

0.22.0

SDK Version

0.22.0

What Exporters are you seeing the problem on?

No response

Relevant log output

No response

@lalitb lalitb added bug Something isn't working triage:todo Needs to be traiged. labels Apr 5, 2024
@lalitb
Copy link
Member Author

lalitb commented Apr 5, 2024

ok the newer version of prost v0.12.4 is adding a header comment in the compiled proto rust files because of below change:

tokio-rs/prost#935

Will recompile the proto files with newer prost version, and raise a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage:todo Needs to be traiged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant