Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename batch span processor delay and timeout env vars #434

Closed
jtescher opened this issue Jan 21, 2021 · 1 comment · Fixed by #459
Closed

Rename batch span processor delay and timeout env vars #434

jtescher opened this issue Jan 21, 2021 · 1 comment · Fixed by #459
Labels
good first issue Good for newcomers

Comments

@jtescher
Copy link
Member

See the spec change for details open-telemetry/opentelemetry-specification#1325

@TommyCpp TommyCpp added the good first issue Good for newcomers label Jan 22, 2021
@samschlegel
Copy link
Contributor

Just leaving a note that when this is done we should make sure to keep compatibility with the old env vars, as reverting back to the defaults for these values can lead to silently dropped spans.

Might try tackling #272 in the next couple weeks which could help people catch regressions like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants