Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide specification for cloud-provider-specific resource attributes #1098

Closed
willarmiros opened this issue Oct 15, 2020 · 1 comment · Fixed by #1099
Closed

Provide specification for cloud-provider-specific resource attributes #1098

willarmiros opened this issue Oct 15, 2020 · 1 comment · Fixed by #1099
Labels
area:semantic-conventions Related to semantic conventions priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:resource Related to the specification/resource directory

Comments

@willarmiros
Copy link
Contributor

willarmiros commented Oct 15, 2020

What are you trying to achieve?

The current resource specs define a broad range of useful attributes that exist for certain types of compute infrastructure regardless of the who provides it, like container.id or faas.name. However there are many other attributes that OpenTelemetry users would appreciate having in their spans which are specific to the cloud/infrastructure provider. For example, AWS Elastic Container Service (ECS) has metadata related to its "tasks" and "launch type" that do not fit neatly into the existing generic attributes.

In order to record these resource attributes in a consistent way across SDKs and the collector, I think their semantic conventions should live here in the OTel spec for resources under a subdirectory like cloud_provider indicating these attributes are only present in a specified provider's resource. For example, cloud_provider/azure could host specific attributes about Azure Functions, cloud_provider/aws could host specific attributes about ECS, etc.

To avoid bloat, we can constrain the core spec to only contain provider-specific resources from the supported cloud_providers, which are currently aws, gcp, and azure.

Additional context.

This is related to #968, except this issue is about vendor-specific resource semantic convention as opposed to those for instrumentation. I will be following up with a PR that proposes a solution shortly. Always open to feedback here and on the PR when open.

@willarmiros willarmiros added the spec:resource Related to the specification/resource directory label Oct 15, 2020
@Oberon00 Oberon00 changed the title Provide specification for provider-specific resource attributes Provide specification for cloud-provider-specific resource attributes Oct 16, 2020
@arminru arminru added the area:semantic-conventions Related to semantic conventions label Oct 16, 2020
@carlosalberto carlosalberto added the release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs label Oct 16, 2020
@carlosalberto
Copy link
Contributor

Marking it as Allowed for GA, as it seems this would be an editorial change & reorganization to decrease bloat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:resource Related to the specification/resource directory
Projects
None yet
4 participants