Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otlp_span not consistent with trace, what we use for the signal / concept #1313

Closed
anuraaga opened this issue Jan 4, 2021 · 3 comments · Fixed by #1318
Closed

otlp_span not consistent with trace, what we use for the signal / concept #1313

anuraaga opened this issue Jan 4, 2021 · 3 comments · Fixed by #1318
Assignees
@carlosalberto
Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:trace Related to the specification/trace directory

Comments

@anuraaga
Copy link
Contributor

anuraaga commented Jan 4, 2021

We have otlp_span exporter to specify an exporter of only traces over OTLP but it would be more consistent with others, including otlp_metrics as otlp_trace - trace is the corresponding signal to metrics, and it is an exporter of trace.
@anuraaga anuraaga added the spec:trace Related to the specification/trace directory label Jan 4, 2021
@anuraaga anuraaga changed the title otlp_span not consistent with trace, what we use for the concept otlp_span not consistent with trace, what we use for the signal / concept Jan 4, 2021
@Oberon00 Oberon00 added the area:sdk Related to the SDK label Jan 4, 2021
@carlosalberto
Copy link
Contributor

Although I'm slightly in favor of this change, quite often we may be technically exporting Spans more than (full) Traces ;) Also, I'm a little bit curious of the impact of this change for SIGs and (and potentially, existing users - yes, even if we are still pre 1.0).

@carlosalberto carlosalberto added the release:required-for-ga Must be resolved before GA release, or nice to have before GA label Jan 4, 2021
@carlosalberto
Copy link
Contributor

Marked as required-for-GA as we either change it now or never.

@trask
Copy link
Member

trask commented Jan 5, 2021

Also, I'm a little bit curious of the impact of this change for SIGs and (and potentially, existing users - yes, even if we are still pre 1.0).

Java Auto-Instrumentation has implemented this, but I don't have concerns changing it prior to 1.0.

@andrewhsu andrewhsu added the priority:p1 Highest priority level label Jan 5, 2021
@anuraaga anuraaga mentioned this issue Jan 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosalberto carlosalberto

Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
5 participants
@andrewhsu @anuraaga @trask @carlosalberto @Oberon00