-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the span class used by Exporters #158
Comments
Moving it to 0.4.0 for now. |
Is this about "SpanData"? |
@SergeyKanzhelev can you please revisit this issue, is it still valid? |
I think we should indeed still define, in the SDK spec, the interface between the exporter and the SpanProcessor. I.e., we pass the Span interface, as specified in the API, that only contains setters, to the SpanProcessor, right? How do we get from that to something "readable" that can be exported? The spec could be as simple as:
But IMHO we should have at least something. |
From the SIG mtg today, sounds like this one would be suitable to be moved to the next milestone. |
@Oberon00 To me it sounds like we have all the pieces now ( |
@carlosalberto Indeed my #669 seems to resolve this issue. A more detailed description would be nice (e.g. is the full parent span context required or just the parent ID + isRemote), but I will add a "resolves" link in #669 (which is not merged yet, so we can't close this just yet 😃) |
Closing this because it looks resolved by #669 |
As pointed out in #669 (comment), after #669 we still have to specify some details on the SpanData/proto.Span/ReadableSpan class, like that resources should be accessible, whether the full parent SpanContext should be accessible (cf. #366), etc. |
from the issue triage mtg today with TC, allowing changes related to this issue for GA if editorial changes only |
I think this was fully resolved with #756. Please reopen if you still see open points. |
Describe the class used by Exporters: how to get it's instance and it's getters/setters
The text was updated successfully, but these errors were encountered: