Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document discrepancy with spec or loosen spec for default value of exporter endpoint #1984

Closed
anuraaga opened this issue Oct 4, 2021 · 1 comment · Fixed by #1997
Closed
Assignees
Labels
area:configuration Related to configuring the SDK area:sdk Related to the SDK spec:miscellaneous For issues that don't match any other spec label

Comments

@anuraaga
Copy link
Contributor

anuraaga commented Oct 4, 2021

I randomly noticed the default value for endpoint for exporter is https://localhost

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#configuration-options

Java uses http://localhost - I think fixing this now would be too disruptive to existing users without enough benefit. Should this be documented here somehow or the spec wording loosened to allow it? FWIW, I believe https://localhost has no real user case and suspect where secure is implemented as the default in the SDK, 100% of users are setting the variable themselves - in case that matters here.

@anuraaga anuraaga added the spec:miscellaneous For issues that don't match any other spec label label Oct 4, 2021
@Oberon00 Oberon00 added area:configuration Related to configuring the SDK area:sdk Related to the SDK labels Oct 4, 2021
@carlosalberto
Copy link
Contributor

@anuraaga We briefly discussed this in the Maintainers meeting and we are fine with loosening this (with a SHOULD, that is). Can you prepare such a PR? Else I can help with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:configuration Related to configuring the SDK area:sdk Related to the SDK spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants