Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify on if schemaUrl is part of InstrumentationLibrary #2133

Open
legendecas opened this issue Nov 17, 2021 · 0 comments
Open

Clarify on if schemaUrl is part of InstrumentationLibrary #2133

legendecas opened this issue Nov 17, 2021 · 0 comments
Assignees
Labels
spec:miscellaneous For issues that don't match any other spec label

Comments

@legendecas
Copy link
Member

What are you trying to achieve?

Ref: open-telemetry/opentelemetry-js#2625 (comment)

In the spec, there are no clear statements about what an instrumentation library info consists of. Likely the InstrumentationLibrary should contain name and version, but the schemaUrl is not clearly stated if it is part of them.

I do find statements like the following that treat those three elements as one pack.

Implementations MUST NOT require users to repeatedly obtain a Meter again with the same name+version+schema_url to pick up configuration changes
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#get-a-meter

Additional context.

Links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
Development

No branches or pull requests

2 participants