Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration for instrumentations through environment variables #2472

Closed
svrnm opened this issue Apr 6, 2022 · 0 comments
Closed

Configuration for instrumentations through environment variables #2472

svrnm opened this issue Apr 6, 2022 · 0 comments
Labels
area:configuration Related to configuring the SDK spec:miscellaneous For issues that don't match any other spec label

Comments

@svrnm
Copy link
Member

svrnm commented Apr 6, 2022

This issue is blocking #2461. Based on the SIG meeting yesterday the overall consensus was that there is a need for a configuration specification (see #1773). Assuming that this will take some time, the question is what to do with existing & future instrumentation configurations? The example with the HTTP headers in #2461 shows that it would be valuable to have a standard here that is consistent across languages.

Copying the detail questions from @tigrannajaryan's comment:

  1. Should instrumentations be configurable via env variables?
  2. Is the same configuration settable from the code?
  3. Is naming of instrumentations' env variables dictated by the spec?
  4. Where in the spec it should live?
  5. What is the variable naming scheme? Do we choose a particular prefix like this PR suggests?
  6. How to name variables which are specific for just one instrumentation and are not generic and applicable to many instrumentations like "OTEL_INSTRUMENTATION_HTTP*" is? Should the variable names be prefixed by the instrumentation library name?
@svrnm svrnm added the spec:miscellaneous For issues that don't match any other spec label label Apr 6, 2022
@arminru arminru added the area:configuration Related to configuring the SDK label Apr 6, 2022
@SergeyKanzhelev SergeyKanzhelev removed their assignment Feb 18, 2023
@svrnm svrnm closed this as not planned Won't fix, can't repro, duplicate, stale May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:configuration Related to configuring the SDK spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
Development

No branches or pull requests

3 participants