Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename http.* attributes to align with ECS #3182

Closed
Tracked by #1012
trask opened this issue Feb 7, 2023 · 0 comments · Fixed by #3355
Closed
Tracked by #1012

Rename http.* attributes to align with ECS #3182

trask opened this issue Feb 7, 2023 · 0 comments · Fixed by #3355
Assignees
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:trace Related to the specification/trace directory

Comments

@trask
Copy link
Member

trask commented Feb 7, 2023

What are you trying to achieve?

Align http.* attributes with corresponding ECS names (see open-telemetry/oteps#222 for motivation).

Rename:

  • http.method -> http.request.method
  • http.status_code -> http.response.status_code
  • http.request_content_length -> http.request.body.bytes
  • http.response_content_length -> http.response.body.bytes

Rename http.resend_count to follow above convention, even though ECS has no corresponding attribute yet:

  • http.resend_count -> http.request.resend_count
@trask trask added the spec:trace Related to the specification/trace directory label Feb 7, 2023
@trask trask self-assigned this Feb 7, 2023
@trask trask added area:semantic-conventions Related to semantic conventions semconv:HTTP labels Feb 7, 2023
@trask trask moved this to Blocker for stability in Spec: HTTP Semantic Conventions Feb 7, 2023
@trask trask moved this from Blocker for stability to Blocker for stability (ECS) in Spec: HTTP Semantic Conventions Feb 14, 2023
@trask trask moved this from Blocker for stability (ECS) to Blocker for stability in Spec: HTTP Semantic Conventions Apr 4, 2023
@github-project-automation github-project-automation bot moved this from Blocker for stability to Done in Spec: HTTP Semantic Conventions May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:trace Related to the specification/trace directory
Projects
2 participants