-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider a new name for Metrics Meter
interface
#365
Comments
Another reason to avoid "Meter" is that it's used in other libraries to mean something quite different. https://metrics.dropwizard.io/4.1.1/manual/core.html#man-core-meters |
We've already decide that this is not very important, because the same reason can be applied to |
Somehow I missed this issue getting created. Currently, the Java APIs, the Part of that confusion is as @jmacd mentioned, because I'm used to working with Micrometer metrics, which has |
Just to pile on, I would say there is a substantial difference between the confusion from |
I don't think we've made progress. I'm inclined to close this. |
I guess so. I still think it's a confusing name for what it is, but if no one else is on board with changing it, then we should close it. I'd love to have some users provide some feedback, rather those of us living in the echo chamber. |
See this comment:
I agree that
Meter
is somehow not quite right. It has the nice property of ending with -er
like Tracer, but otherwise the word "Meter" in common language does not describe a measuring device. I've been using "Instrument" to describe the things returned by this interface, but even "Instrumenter" isn't much of a word. Maybe "Meters" is OK, but I'd actually prefer "Metrics" in one form for this concept. As is being discussed in #354 for Tracers, maybe something like "MetricsSource" or "MetricsRoot" works?The text was updated successfully, but these errors were encountered: