Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a new name for Metrics Meter interface #365

Closed
jmacd opened this issue Nov 25, 2019 · 6 comments
Closed

Consider a new name for Metrics Meter interface #365

jmacd opened this issue Nov 25, 2019 · 6 comments
Labels
spec:metrics Related to the specification/metrics directory

Comments

@jmacd
Copy link
Contributor

jmacd commented Nov 25, 2019

See this comment:

On the "The/A" distinction: For me, the name Meter is an odd one, in that I think of a "meter" as a thing that measures something, rather than a source of very many things that measure a wide variety of things. I know we're trying to avoid the Factory word, but having this be a singular english noun is quite confusing to me. Meters would be more evocative.

I agree that Meter is somehow not quite right. It has the nice property of ending with -er like Tracer, but otherwise the word "Meter" in common language does not describe a measuring device. I've been using "Instrument" to describe the things returned by this interface, but even "Instrumenter" isn't much of a word. Maybe "Meters" is OK, but I'd actually prefer "Metrics" in one form for this concept. As is being discussed in #354 for Tracers, maybe something like "MetricsSource" or "MetricsRoot" works?

@jmacd jmacd added the spec:metrics Related to the specification/metrics directory label Nov 25, 2019
@jmacd
Copy link
Contributor Author

jmacd commented Dec 3, 2019

Another reason to avoid "Meter" is that it's used in other libraries to mean something quite different.

https://metrics.dropwizard.io/4.1.1/manual/core.html#man-core-meters

@bogdandrutu
Copy link
Member

Another reason to avoid "Meter" is that it's used in other libraries to mean something quite different.

We've already decide that this is not very important, because the same reason can be applied to Gauge and that is probably more important than Meter.

@jkwatson
Copy link
Contributor

Somehow I missed this issue getting created.

Currently, the Java APIs, the Meter is the "factory" class for creating builders (sigh, java) for the various Metric implementations. Hence, Metrics feels like an excellent, easy-to-grok place to go to create your Metrics, whereas Meter is just confusing (to me).

Part of that confusion is as @jmacd mentioned, because I'm used to working with Micrometer metrics, which has Meter as the base interface for all the various kind of instruments provided.

@jmacd
Copy link
Contributor Author

jmacd commented Dec 16, 2019

Just to pile on, I would say there is a substantial difference between the confusion from Meter as compared with Gauge. The OTel Gauge is the same kind of thing -- an instrument -- as it is in many APIs. The OTel Meter is a different kind of thing -- a reference to the SDK -- than in the Micrometer / DropWizard APIs.

@jmacd
Copy link
Contributor Author

jmacd commented Feb 20, 2020

I don't think we've made progress. I'm inclined to close this.

@jkwatson
Copy link
Contributor

I guess so. I still think it's a confusing name for what it is, but if no one else is on board with changing it, then we should close it. I'd love to have some users provide some feedback, rather those of us living in the echo chamber.

@jmacd jmacd closed this as completed May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

No branches or pull requests

3 participants